commit 29e0594f3da103f1ece51fe40ba09faa1c691972
from: Stefan Sperling <stsp@stsp.name>
date: Sat Apr 09 17:34:51 2022 UTC

make gotadmin pack -x option work with tag arguments

commit - 67ba61612157092fbe0f8c4a02b60faf31967061
commit + 29e0594f3da103f1ece51fe40ba09faa1c691972
blob - 2367bbad785100530c52f743fc7c907cc20af73f
blob + 63e87912816262a1fbf2409860698652afca6344
--- lib/pack_create.c
+++ lib/pack_create.c
@@ -1214,6 +1214,37 @@ append_id(struct got_object_id *id, void *data, void *
 
 	a->idx++;
 	return NULL;
+}
+
+static const struct got_error *
+queue_commit_or_tag_id(struct got_object_id *id, int color,
+    struct got_object_id_queue *ids, struct got_repository *repo)
+{
+	const struct got_error *err;
+	struct got_tag_object *tag = NULL;
+	int obj_type;
+
+	err = got_object_get_type(&obj_type, repo, id);
+	if (err)
+		return err;
+
+	if (obj_type == GOT_OBJ_TYPE_TAG) {
+		err = got_object_open_as_tag(&tag, repo, id);
+		if (err)
+			return err;
+		obj_type = got_object_tag_get_object_type(tag);
+		id = got_object_tag_get_object_id(tag);
+	}
+
+	if (obj_type == GOT_OBJ_TYPE_COMMIT) {
+		err = queue_commit_id(ids, id, color, repo);
+		if (err)
+			goto done;
+	}
+done:
+	if (tag)
+		got_object_tag_close(tag);
+	return err;
 }
 
 static const struct got_error *
@@ -1228,7 +1259,7 @@ findtwixt(struct got_object_id ***res, int *nres, int 
 	struct got_object_id_queue ids;
 	struct got_object_idset *keep, *drop;
 	struct got_object_qid *qid;
-	int i, ncolor, nkeep, obj_type;
+	int i, ncolor, nkeep;
 
 	STAILQ_INIT(&ids);
 	*res = NULL;
@@ -1249,25 +1280,16 @@ findtwixt(struct got_object_id ***res, int *nres, int 
 		struct got_object_id *id = head[i];
 		if (id == NULL)
 			continue;
-		err = got_object_get_type(&obj_type, repo, id);
-		if (err)
-			return err;
-		if (obj_type != GOT_OBJ_TYPE_COMMIT)
-			continue;
-		err = queue_commit_id(&ids, id, COLOR_KEEP, repo);
+		err = queue_commit_or_tag_id(id, COLOR_KEEP, &ids, repo);
 		if (err)
 			goto done;
 	}		
+
 	for (i = 0; i < ntail; i++) {
 		struct got_object_id *id = tail[i];
 		if (id == NULL)
 			continue;
-		err = got_object_get_type(&obj_type, repo, id);
-		if (err)
-			return err;
-		if (obj_type != GOT_OBJ_TYPE_COMMIT)
-			continue;
-		err = queue_commit_id(&ids, id, COLOR_DROP, repo);
+		err = queue_commit_or_tag_id(id, COLOR_DROP, &ids, repo);
 		if (err)
 			goto done;
 	}
blob - 3f911d52d624e56029f65b90ea0a9203bbf8def6
blob + 943365b98b4c77208dff732937dfafcd5fe825a7
--- regress/cmdline/pack.sh
+++ regress/cmdline/pack.sh
@@ -170,6 +170,112 @@ test_pack_exclude() {
 	test_done "$testroot" "$ret"
 }
 
+test_pack_exclude_tag() {
+	local testroot=`test_init pack_exclude_tag`
+	local commit0=`git_show_head $testroot/repo`
+
+	# no pack files should exist yet
+	ls $testroot/repo/.git/objects/pack/ > $testroot/stdout
+	ret=$?
+	if [ $ret -ne 0 ]; then
+		test_done "$testroot" "$ret"
+		return 1
+	fi
+	echo -n > $testroot/stdout.expected
+	cmp -s $testroot/stdout.expected $testroot/stdout
+	ret=$?
+	if [ $ret -ne 0 ]; then
+		diff -u $testroot/stdout.expected $testroot/stdout
+		test_done "$testroot" "$ret"
+		return 1
+	fi
+
+	got tag -r $testroot/repo -m 1.0 -c master 1.0 > /dev/null
+	ret=$?
+	if [ $ret -ne 0 ]; then
+		test_done "$testroot" "$ret"
+		return 1
+	fi
+
+	got branch -r $testroot/repo mybranch
+	ret=$?
+	if [ $ret -ne 0 ]; then
+		test_done "$testroot" "$ret"
+		return 1
+	fi
+
+	got checkout -b mybranch $testroot/repo $testroot/wt > /dev/null
+	ret=$?
+	if [ $ret -ne 0 ]; then
+		test_done "$testroot" "$ret"
+		return 1
+	fi
+
+	echo a new line >> $testroot/wt/alpha
+	(cd $testroot/wt && got commit -m "edit alpha" >/dev/null)
+
+	gotadmin pack -r $testroot/repo -x refs/tags/1.0 > $testroot/stdout
+	ret=$?
+	if [ $ret -ne 0 ]; then
+		echo "gotadmin pack failed unexpectedly" >&2
+		test_done "$testroot" "$ret"
+		return 1
+	fi
+	packname=`grep ^Wrote $testroot/stdout | cut -d ' ' -f2`
+	gotadmin listpack $testroot/repo/.git/objects/pack/pack-$packname \
+		> $testroot/stdout
+
+	tree0=`got cat -r $testroot/repo $commit0 | grep ^tree | \
+		cut -d ' ' -f2`
+	tag0=`got tag -l -r $testroot/repo | grep ^tag | cut -d ' ' -f3`
+	excluded_ids=`got tree -r $testroot/repo -c $commit0 -R -i | \
+		cut -d ' ' -f 1`
+	excluded_ids="$excluded_ids $commit0 $tree0 $tag0"
+	for id in $excluded_ids; do
+		ret=0
+		if grep -q ^$id $testroot/stdout; then
+			echo "found excluded object $id in pack file" >&2
+			ret=1
+		fi
+		if [ $ret -eq 1 ]; then
+			break
+		fi
+	done
+	if [ $ret -eq 1 ]; then
+		test_done "$testroot" "$ret"
+		return 1
+	fi
+
+	for d in $testroot/repo/.git/objects/[0-9a-f][0-9a-f]; do
+		id0=`basename $d`
+		ret=0
+		for e in `ls $d`; do
+			obj_id=${id0}${e}
+			excluded=0
+			for id in $excluded_ids; do
+				if [ "$obj_id" = "$id" ]; then
+					excluded=1
+					break
+				fi
+			done
+			if [ "$excluded" = "1" ]; then
+				continue
+			fi
+			if grep -q ^$obj_id $testroot/stdout; then
+				continue
+			fi
+			echo "loose object $obj_id was not packed" >&2
+			ret=1
+			break
+		done
+		if [ $ret -eq 1 ]; then
+			break
+		fi
+	done
+
+	test_done "$testroot" "$ret"
+}
+
 test_pack_include() {
 	local testroot=`test_init pack_include`
 	local commit0=`git_show_head $testroot/repo`
@@ -573,6 +679,7 @@ test_pack_bad_ref() {
 test_parseargs "$@"
 run_test test_pack_all_loose_objects
 run_test test_pack_exclude
+run_test test_pack_exclude_tag
 run_test test_pack_include
 run_test test_pack_ambiguous_arg
 run_test test_pack_loose_only