commit 2cb49fa8fb84f3a8fc2eb6036a6bd9b64c57e347
from: Stefan Sperling <stsp@stsp.name>
date: Fri May 10 23:41:58 2019 UTC

revert eb73a30f7effc51c1cfee2864102635e3659f87a

Not waiting for children can make us blow the fork() ulimit with
lingering zombies; the Ctrl-C issue will need some other fix.

commit - df613bb4d8662c28a9888714a80ca572bff9d924
commit + 2cb49fa8fb84f3a8fc2eb6036a6bd9b64c57e347
blob - 7e6cbb92158fae37548623fa806cb03a13e55320
blob + 1dd388018dac2f2a4e0f290a8a60976d4140796e
--- lib/privsep.c
+++ lib/privsep.c
@@ -95,8 +95,8 @@ got_privsep_wait_for_child(pid_t pid)
 {
 	int child_status;
 
-	if (waitpid(pid, &child_status, WNOHANG) == 0)
-		return NULL;
+	if (waitpid(pid, &child_status, 0) == -1)
+		return got_error_from_errno();
 
 	if (!WIFEXITED(child_status))
 		return got_error(GOT_ERR_PRIVSEP_DIED);