commit 2eb11d8ec14963a978a1811f5d0beca158d64f50
from: Omar Polo <op@omarpolo.com>
date: Sun Oct 04 13:31:39 2020 UTC

rework send_fake: copy as much as possible from the original event

send_fake now copies almost all field from the original event, except
for the the window, keycode and state field.

When we grab a key we grab it onto the root window, so every event we
receive has a field window that is equal to the root.  (this will
change in the future), so we need to change that.

The keycode and state obviously need to be changed, it's the whole
point of the function.

It doesn't seem to fix the known bug that occur in dino thought.

commit - 7c6a610b98e344ef485f60862db46ec271a50c5a
commit + 2eb11d8ec14963a978a1811f5d0beca158d64f50
blob - ebe717c4d4a3395fcf52d2aba753bcf331bed9dd
blob + 3db20884656eaba3dcb161b08b5c75559f043122
--- star-platinum.c
+++ star-platinum.c
@@ -271,28 +271,33 @@ focused_window()
 }
 
 void
-send_fake(Window w, struct key k, int pressed)
+send_fake(Window w, struct key k, XKeyEvent *original)
 {
 	XKeyEvent e;
 
-	e.type = pressed ? KeyPress : KeyRelease;
-
-	e.display = d;
-	e.window = w;
-	e.root = DefaultRootWindow(d);
-	e.subwindow = None;
-	e.time = CurrentTime;
+	/*
+	 * this needs to be hijacked. original->window is the root
+	 * window (since we grabbed the key there) and we want to
+	 * deliver the key to another window.
+	 */
+	e.window = w;
 
-	/* TODO: fix these */
-	e.x = 1;
-	e.y = 1;
-	e.x_root = 1;
-	e.y_root = 1;
-
-	e.same_screen = True;
+	/* this is the fake key */
 	e.keycode = XKeysymToKeycode(d, k.key);
 	e.state = k.modifier;
 
+	/* the rest is just copying fields from the original event */
+	e.type = original->type;
+	e.display = original->display;
+	e.root = original->root;
+	e.subwindow = original->subwindow;
+	e.time = original->time;
+	e.same_screen = original->same_screen;
+	e.x = original->x;
+	e.y = original->y;
+	e.x_root = original->x_root;
+	e.y_root = original->y_root;
+
 	XSendEvent(d, w, True, KeyPressMask, (XEvent*)&e);
 	XFlush(d);
 }
@@ -320,11 +325,11 @@ window_match_class(Window w, const char *class)
 /* action */
 
 void
-do_action(struct action a, Window focused, int pressed)
+do_action(struct action a, Window focused, XKeyEvent *original)
 {
 	switch (a.type) {
 	case AFAKE:
-		send_fake(focused, a.send_key, pressed);
+		send_fake(focused, a.send_key, original);
 		break;
 
 	case ASPECIAL:
@@ -510,13 +515,13 @@ process_event(struct group *g, XKeyEvent *e)
 
 		for (r = g->rules; r != NULL; r = r->next) {
 			if (rule_matched(r, pressed)) {
-				do_action(r->action, focused, e->type == KeyPress);
+				do_action(r->action, focused, e);
 				return;
 			}
 		}
 	}
 
-	send_fake(focused, pressed, e->type == KeyPress);
+	send_fake(focused, pressed, e);
 }
 
 int
blob - f6a752b1d4a5b367add9cb6b943f2d63a5a816d3
blob + 83905bdcc9785249932bafd61fc815e1e9a09cc6
--- star-platinum.h
+++ star-platinum.h
@@ -50,7 +50,7 @@ struct action {
 	};
 };
 
-void			 do_action(struct action, Window, int);
+void			 do_action(struct action, Window, XKeyEvent*);
 void			 free_action(struct action);
 
 struct match {
@@ -93,7 +93,7 @@ int			 error_handler(Display*, XErrorEvent*);
 void			 grabkey(struct key);
 KeySym			 keycode_to_keysym(unsigned int);
 Window			 focused_window();
-void			 send_fake(Window, struct key, int);
+void			 send_fake(Window, struct key, XKeyEvent*);
 int			 window_match_class(Window, const char*);
 
 /* debugging */