commit 2fc68b6d8ebc0479318fa9764bfaa7ff58165fc3 from: David du Colombier <0intro@gmail.com> via: Russ Cox date: Tue Nov 22 19:09:52 2011 UTC mailfs: small fixes and plan 9 support R=rsc CC=plan9port.codebot http://codereview.appspot.com/5429044 commit - bd51695c9278f9321d420a43a16f575471f32476 commit + 2fc68b6d8ebc0479318fa9764bfaa7ff58165fc3 blob - f30e51c177dad7f2f9d26b2bdca9a2b483789b05 blob + bca2c96268ec22f8ef8318ea15b4dae3011fc1dc --- src/cmd/upas/nfs/a.h +++ src/cmd/upas/nfs/a.h @@ -6,6 +6,7 @@ #include #include #include <9p.h> +#include enum { @@ -44,3 +45,5 @@ extern Imap *imap; #define erealloc realloc #define estrdup strdup +#pragma varargck type "$" Sx* +#pragma varargck type "Z" char* blob - f7a52bc508dc7564b6aff7d7a6961455dca13f38 blob + 202111f8e860c5c49904f5b355b83b5d3a370347 --- src/cmd/upas/nfs/box.c +++ src/cmd/upas/nfs/box.c @@ -208,7 +208,11 @@ msgplumb(Msg *m, int delete) a[ai].next = nil; p.attr = a; +#ifdef PLAN9PORT snprint(buf, sizeof buf, "Mail/%s/%ud", m->box->name, m->id); +#else + snprint(buf, sizeof buf, "/mail/fs/%s/%ud", m->box->name, m->id); +#endif p.ndata = strlen(buf); p.data = buf; blob - fd44c964b621650f81010c420d2d77a790cd4d14 blob + ee5c2b9bca44242e6551aed0b535a8c19649caf7 --- src/cmd/upas/nfs/fs.c +++ src/cmd/upas/nfs/fs.c @@ -93,6 +93,7 @@ Srv fs; Qid rootqid; ulong t0; +#ifdef PLAN9PORT void responderror(Req *r) { @@ -101,6 +102,7 @@ responderror(Req *r) rerrstr(e, sizeof e); respond(r, e); } +#endif int qtype(Qid q) @@ -378,7 +380,8 @@ mkbody(Part *p, Qid q) { char *t; int len; - + + USED(q); if(p->msg->part[0] == p) t = p->rawbody; else @@ -571,7 +574,7 @@ filedata(int type, Box *box, Msg *msg, Part *part, cha fmtstrinit(&fmt); if(part == msg->part[0]){ if(msg->date) - fmtprint(&fmt, "unixdate %lud %s", msg->date, ctime(msg->date)); + fmtprint(&fmt, "unixdate %ud %s", msg->date, ctime(msg->date)); if(msg->flags){ filedata(Qflags, box, msg, part, pp, nil, freeme, 0, ZQ); fmtprint(&fmt, "flags %s\n", buf); @@ -1202,7 +1205,8 @@ static void fsrecv(void *v) { Req *r; - + + USED(v); while((r = recvp(fsreqchan)) != nil){ switch(r->ifcall.type){ case Tattach: blob - e5b8e5ca2481e74b299a6fd10ca6b9521258b047 blob + 7523a4478a2e3ef69ee7c1f9d7958a80a2bcd47f --- src/cmd/upas/nfs/imap.c +++ src/cmd/upas/nfs/imap.c @@ -754,12 +754,16 @@ imapdial(char *server, int mode) fd[0] = dup(p[0], -1); fd[1] = dup(p[0], -1); fd[2] = dup(2, -1); +#ifdef PLAN9PORT tmp = esmprint("%s:993", server); - if(threadspawnl(fd, "tlsclient", "tlsclient", tmp, nil) < 0 - && threadspawnl(fd, "/usr/sbin/stunnel3", "stunnel3", "-c", "-r", tmp, nil) < 0 + if(threadspawnl(fd, "/usr/sbin/stunnel3", "stunnel3", "-c", "-r", tmp, nil) < 0 && threadspawnl(fd, "/usr/bin/stunnel3", "stunnel3", "-c", "-r", tmp, nil) < 0 && threadspawnl(fd, "/usr/sbin/stunnel", "stunnel", "-c", "-r", tmp, nil) < 0 && threadspawnl(fd, "/usr/bin/stunnel", "stunnel", "-c", "-r", tmp, nil) < 0){ +#else + tmp = esmprint("tcp!%s!993", server); + if(threadspawnl(fd, "/bin/tlsclient", "tlsclient", tmp, nil) < 0){ +#endif free(tmp); close(p[0]); close(p[1]); @@ -1300,6 +1304,8 @@ xexists(Imap *z, Sx *sx) static void xflags(Imap *z, Sx *sx) { + USED(z); + USED(sx); /* * This response contains in sx->sx[2] the list of flags * that can be validly attached to messages in z->box. @@ -1311,6 +1317,7 @@ xflags(Imap *z, Sx *sx) static void xbye(Imap *z, Sx *sx) { + USED(sx); close(z->fd); z->fd = -1; z->connected = 0; @@ -1496,6 +1503,7 @@ copyaddrs(Sx *v) static void xmsgenvelope(Msg *msg, Sx *k, Sx *v) { + USED(k); hdrfree(msg->part[0]->hdr); msg->part[0]->hdr = parseenvelope(v); msgplumb(msg, 0); @@ -1601,6 +1609,7 @@ parsestructure(Part *part, Sx *v) static void xmsgbody(Msg *msg, Sx *k, Sx *v) { + USED(k); if(v->type != SxList){ warn("bad body: %$", v); return; @@ -1742,24 +1751,32 @@ xokuidvalidity(Imap *z, Sx *sx) static void xokpermflags(Imap *z, Sx *sx) { + USED(z); + USED(sx); /* z->permflags = parseflags(sx); */ } static void xokunseen(Imap *z, Sx *sx) { + USED(z); + USED(sx); /* z->unseen = sx->number; */ } static void xokreadwrite(Imap *z, Sx *sx) { + USED(z); + USED(sx); /* z->boxmode = ORDWR; */ } static void xokreadonly(Imap *z, Sx *sx) { + USED(z); + USED(sx); /* z->boxmode = OREAD; */ } blob - 3f3d2aa63fe749dc891de7df33ed88ae1a051bb8 blob + e5d9954ee54a38a4755b8a18615ce8b4831e4d68 --- src/cmd/upas/nfs/imap.h +++ src/cmd/upas/nfs/imap.h @@ -1,4 +1,5 @@ typedef struct Imap Imap; +#pragma incomplete Imap void imapcheckbox(Imap *z, Box *b); Imap* imapconnect(char *server, int mode, char *root); blob - 710a33d719bec6da401ee410c447417194ddfa74 blob + bb40def13ac755337573f4b0b3d357d2e232cf56 --- src/cmd/upas/nfs/thread.c +++ src/cmd/upas/nfs/thread.c @@ -24,6 +24,7 @@ mailproc(void *v) { New n; + USED(v); while(recv(mailthreadchan, &n) == 1) threadcreate(n.fn, n.arg, STACK); }