commit 3997bf418a991d9a94f4284197da238412f8bf7c
from: Omar Polo <omar.polo@europecom.net>
date: Fri May 25 21:44:28 2018 UTC

fixed memory leak + new checks for NULL values

commit - 8ecd98cc9ee4478187cb6adc0034ac75a5f2ce36
commit + 3997bf418a991d9a94f4284197da238412f8bf7c
blob - 6a0042a6c04bda58dfac2e11d5b3a4c1697868a2
blob + ac7562584a605267d1889af8cfbad7f39c171e7f
--- mymenu.c
+++ mymenu.c
@@ -43,7 +43,7 @@
 #endif
 
 #define update_completions(cs, text, lines) {   \
-    compl_delete(cs);                           \
+    compl_delete_rec(cs);                       \
     cs = filter(text, lines);                   \
   }
 
@@ -128,6 +128,14 @@ void compl_delete(struct completions *c) {
   free(c);
 }
 
+void compl_delete_rec(struct completions *c) {
+  while (c != nil) {
+    struct completions *t = c->next;
+    free(c);
+    c = t;
+  }
+}
+
 struct completions *compl_select_next(struct completions *c, bool n) {
   if (c == nil)
     return nil;
@@ -187,6 +195,8 @@ struct completions *filter(char *text, char **lines) {
   int i = 0;
   struct completions *root = compl_new();
   struct completions *c = root;
+  if (c == nil)
+    return nil;
 
   for (;;) {
     char *l = lines[i];
@@ -196,6 +206,10 @@ struct completions *filter(char *text, char **lines) {
     if (strcasestr(l, text) != nil) {
       c->next = compl_new();
       c = c->next;
+      if (c == nil) {
+        compl_delete_rec(root);
+        return nil;
+      }
       c->completion = l;
     }
 
@@ -693,7 +707,6 @@ int main() {
   if (XineramaIsActive(d)) {
     // find the mice
     int number_of_screens = XScreenCount(d);
-    bool result;
     Window r;
     Window root;
     int root_x, root_y, win_x, win_y;