commit 40831471082f880a26b73987b595a52dc1c93794
from: Josh Rickmar <jrick@zettaport.com>
date: Wed Aug 24 13:35:39 2022 UTC

don't create signed tag objects with trailing NUL

Although Git itself did not care, the superfluous NUL at the end of
the tag object was breaking GitHub's SSH signature detection.

ok stsp@

commit - 4d648b92ac1ac5f952a42f29052c56e8d32547a3
commit + 40831471082f880a26b73987b595a52dc1c93794
blob - d04cf5a35d684cf2759fc02be9b1dc9887309ebb
blob + 670e15b4f8e9326fc92edea6272e06bd3e072a60
--- lib/object_create.c
+++ lib/object_create.c
@@ -748,10 +748,7 @@ got_object_tag_create(struct got_object_id **id,
 		err = buf_load_fd(&buf, out_fd);
 		if (err)
 			goto done;
-		sig_len = buf_len(buf) + 1;
-		err = buf_putc(buf, '\0');
-		if (err)
-			goto done;
+		sig_len = buf_len(buf);
 		if (close(out_fd) == -1) {
 			err = got_error_from_errno("close");
 			goto done;