commit 578133c9903e5620b4601f9c0f178f530d28722f
from: Christian Weisgerber <naddy@mips.inka.de>
date: Sat Nov 28 18:28:10 2020 UTC

replace echo with printf, stop option processing with "--" for portability

ok stsp

commit - 9a1d514689bb6e57bb47e4c13630ba38bd650a39
commit + 578133c9903e5620b4601f9c0f178f530d28722f
blob - 883be7a1fb5bdd2de7ed9df74a676c22d4a2c869
blob + 83704789bb28cdc3cbe2a2d8966b886174960585
--- regress/cmdline/diff.sh
+++ regress/cmdline/diff.sh
@@ -619,7 +619,7 @@ test_diff_binary_files() {
 	echo '+++ foo' >> $testroot/stdout.expected
 	echo '@@ -0,0 +1 @@' >> $testroot/stdout.expected
 	printf '+\377\377\0\0\377\377\0\0\n' >> $testroot/stdout.expected
-	echo '\\ No newline at end of file' >> $testroot/stdout.expected
+	printf '\\ No newline at end of file\n' >> $testroot/stdout.expected
 
 	(cd $testroot/wt && got diff -a > $testroot/stdout)
 	cmp -s $testroot/stdout.expected $testroot/stdout
@@ -643,10 +643,10 @@ test_diff_binary_files() {
 	echo '--- foo' >> $testroot/stdout.expected
 	echo '+++ foo' >> $testroot/stdout.expected
 	echo '@@ -1 +1 @@' >> $testroot/stdout.expected
-	printf '-\377\377\0\0\377\377\0\0\n' >> $testroot/stdout.expected
-	echo '\\ No newline at end of file' >> $testroot/stdout.expected
+	printf -- '-\377\377\0\0\377\377\0\0\n' >> $testroot/stdout.expected
+	printf '\\ No newline at end of file\n' >> $testroot/stdout.expected
 	printf '+\377\200\0\0\377\200\0\0\n' >> $testroot/stdout.expected
-	echo '\\ No newline at end of file' >> $testroot/stdout.expected
+	printf '\\ No newline at end of file\n' >> $testroot/stdout.expected
 
 	(cd $testroot/wt && got diff -a > $testroot/stdout)
 	cmp -s $testroot/stdout.expected $testroot/stdout