commit 6977f45a0d6e4dceb507913771e10106042dbaca
from: Omar Polo <op@omarpolo.com>
date: Fri Sep 02 14:04:52 2022 UTC

gotwebd: avoid extra variable in got_output_repo_tree

in_repo_path was used only to build a path, it's then assigned to path
(which is NULL at that point.)  Just asprintf into path.

ok stsp@

commit - 8d4a8ca19cca1354c4d99d5df888c3c9b56e075c
commit + 6977f45a0d6e4dceb507913771e10106042dbaca
blob - 5ea76c0eefd10ebe0ddf57279275a15c27edd525
blob + f500314c106449c5c3d6cfec055ece7d261e05bb
--- gotwebd/got_operations.c
+++ gotwebd/got_operations.c
@@ -817,7 +817,7 @@ got_output_repo_tree(struct request *c)
 	struct repo_dir *repo_dir = t->repo_dir;
 	const char *name, *index_page_str, *folder;
 	char *id_str = NULL, *escaped_name = NULL;
-	char *path = NULL, *in_repo_path = NULL, *modestr = NULL;
+	char *path = NULL, *modestr = NULL;
 	int nentries, i, r;
 
 	TAILQ_INIT(&refs);
@@ -831,11 +831,9 @@ got_output_repo_tree(struct request *c)
 			goto done;
 		}
 	} else {
-		error = got_repo_map_path(&in_repo_path, repo, repo_dir->path);
+		error = got_repo_map_path(&path, repo, repo_dir->path);
 		if (error)
 			goto done;
-		free(path);
-		path = in_repo_path;
 	}
 
 	error = got_repo_match_object_id(&commit_id, NULL, rc->commit_id,