commit bd8f9db2019dd7141a39f72b69474965b0d34c36 from: Kenny Levinsen date: Wed May 25 20:28:44 2016 UTC Remove tag defaulting in newFcall Defaulting the tag in newFcall might result in unexpected behaviour. For example, if a client (erroneously) sends a Tversion on a tag, the server response will not be on a tag. newFcall should just create the struct. Signed-off-by: Kenny Levinsen commit - bd8041e2db487f6103f3063b177ac4a499ab345e commit + bd8f9db2019dd7141a39f72b69474965b0d34c36 blob - e17a6b70611d29e021f7791f0ef72032b4c16c27 blob + e7b76521e84d5fdbe9dc8059e923ee9cbd01f144 --- fcall.go +++ fcall.go @@ -111,11 +111,6 @@ type Fcall struct { } func newFcall(tag Tag, msg Message) *Fcall { - switch msg.Type() { - case Tversion, Rversion: - tag = NOTAG - } - return &Fcall{ Type: msg.Type(), Tag: tag,