commit c976381d67e1c1ff16f155cbcc6c905245d0520f from: Dan Cross via: Gleydson Soares date: Fri May 05 20:04:17 2017 UTC factotum: Fix an operator precedence bug in the secstore code `==` is higher precedence than `&`. Parenthesize. Change-Id: I2c7ee588fea0d8a66e1c8424f26630015388d61a Signed-off-by: Dan Cross Reviewed-on: https://plan9port-review.googlesource.com/2860 Reviewed-by: Gleydson Soares commit - 9e52ea8a29db42f37188fd8fa35d641724c3d015 commit + c976381d67e1c1ff16f155cbcc6c905245d0520f blob - 2babf4d8e2f65a2f23069b744956017b66faff85 blob + c17c3cf2784b6d1b5334e142e21b3887c6963bfe --- src/cmd/auth/factotum/secstore.c +++ src/cmd/auth/factotum/secstore.c @@ -181,7 +181,7 @@ SC_read(SConn *conn, uchar *buf, int n) uchar count[2], digest[SHA1dlen]; int len, nr; - if(read(ss->fd, count, 2) != 2 || count[0]&0x80 == 0){ + if(read(ss->fd, count, 2) != 2 || (count[0]&0x80) == 0){ werrstr("!SC_read invalid count"); return -1; }