commit de2b82f3b95e95070d83077e7bb0f24f82ae7426
from: Omar Polo <op@omarpolo.com>
date: Sun Jun 18 22:24:47 2023 UTC

retire GOT_ERR_QUERYSTRING

it's redundant with GOT_ERR_BAD_QUERYSTRING; convert its only use
to the latter.

commit - ea4587d81c5314a815505962a77ccfdfc9b4c666
commit + de2b82f3b95e95070d83077e7bb0f24f82ae7426
blob - 57acfb3983fd313a2a166e1c1296ed5262cb5b3d
blob + c775066084109268a1ca7a0f0a2c8cf87ecb209a
--- gotwebd/gotweb.c
+++ gotwebd/gotweb.c
@@ -190,7 +190,7 @@ gotweb_process_request(struct request *c)
 	if (qs->action == BLAME || qs->action == BLOB ||
 	    qs->action == BLOBRAW || qs->action == DIFF) {
 		if (qs->commit == NULL) {
-			error = got_error(GOT_ERR_QUERYSTRING);
+			error = got_error(GOT_ERR_BAD_QUERYSTRING);
 			goto err;
 		}
 	}
blob - 0582e35816efd0e75172f961b9d274e6c249d83d
blob + c7c5ce296704a7d0c3345092eccebd5837fcd453
--- include/got_error.h
+++ include/got_error.h
@@ -131,7 +131,7 @@
 #define GOT_ERR_GITCONFIG_SYNTAX 114
 #define GOT_ERR_REBASE_OUT_OF_DATE 115
 #define GOT_ERR_CACHE_DUP_ENTRY	116
-#define GOT_ERR_QUERYSTRING	117
+/* 117 is currently unused */
 #define GOT_ERR_FETCH_FAILED	118
 #define GOT_ERR_PARSE_URI	119
 #define GOT_ERR_BAD_PROTO	120
blob - feebeac691a9e648011aa46d28905422aae9db1a
blob + 765efe263e09f28dfd6b925eaa64ee0ffe226a3b
--- lib/error.c
+++ lib/error.c
@@ -171,7 +171,6 @@ static const struct got_error got_errors[] = {
 	{ GOT_ERR_REBASE_OUT_OF_DATE, "work tree must be updated before it "
 	    "can be used to rebase a branch" },
 	{ GOT_ERR_CACHE_DUP_ENTRY, "duplicate cache entry" },
-	{ GOT_ERR_QUERYSTRING, "bad querystring" },
 	{ GOT_ERR_FETCH_FAILED, "fetch failed" },
 	{ GOT_ERR_PARSE_URI, "failed to parse uri" },
 	{ GOT_ERR_BAD_PROTO, "unknown protocol" },