commit edd02c5ef605c892d439fa0e57c140a618f4f4ab
from: Stefan Sperling <stsp@stsp.name>
date: Thu Jul 11 12:22:42 2019 UTC

bump fileindex base commit IDs after rebasing a commit

commit - ff0d2220eb012a3bb8f5e583df7baad033a9397b
commit + edd02c5ef605c892d439fa0e57c140a618f4f4ab
blob - d2d08424909784426a78b271004e0f54feb5eeeb
blob + c2920bff83d18f2cd093f31e9d8960b62b6ba815
--- lib/worktree.c
+++ lib/worktree.c
@@ -1496,7 +1496,9 @@ bump_base_commit_id(void *arg, struct got_fileindex_en
 	    SHA1_DIGEST_LENGTH) == 0)
 		return NULL;
 
-	(*a->progress_cb)(a->progress_arg, GOT_STATUS_BUMP_BASE, ie->path);
+	if (a->progress_cb)
+		(*a->progress_cb)(a->progress_arg, GOT_STATUS_BUMP_BASE,
+		    ie->path);
 	memcpy(ie->commit_sha1, a->base_commit_id->sha1, SHA1_DIGEST_LENGTH);
 	return NULL;
 }
@@ -3768,6 +3770,37 @@ done:
 	free(fileindex_path);
 	if (commit_ref)
 		got_ref_close(commit_ref);
+	return err;
+}
+
+static const struct got_error *
+bump_all_base_commit_ids(struct got_worktree *worktree,
+    struct got_object_id *base_commit_id)
+{
+	const struct got_error *err = NULL, *sync_err;
+	struct got_fileindex *fileindex;
+	char *fileindex_path;
+	struct bump_base_commit_id_arg bbc_arg;
+
+	err = open_fileindex(&fileindex, &fileindex_path, worktree);
+	if (err)
+		return err;
+
+	bbc_arg.base_commit_id = base_commit_id;
+	bbc_arg.entry_name = NULL;
+	bbc_arg.path = "";
+	bbc_arg.path_len = 0;
+	bbc_arg.progress_cb = NULL;
+	bbc_arg.progress_arg = NULL;
+	err = got_fileindex_for_each_entry_safe(fileindex,
+	    bump_base_commit_id, &bbc_arg);
+
+	sync_err = sync_fileindex(fileindex, fileindex_path);
+	if (sync_err && err == NULL)
+		err = sync_err;
+
+	got_fileindex_free(fileindex);
+	free(fileindex_path);
 	return err;
 }
 
@@ -3814,6 +3847,11 @@ got_worktree_rebase_commit(struct got_object_id **new_
 		goto done;
 	}
 
+	/* Prevent out-of-date errors during rebase of subsequent commits. */
+	err = bump_all_base_commit_ids(worktree, *new_commit_id);
+	if (err)
+		goto done;
+
 	err = got_ref_delete(commit_ref, repo);
 	if (err)
 		goto done;