commit f52b87018ad3a5b7f5dd2b21260bb2b0eb0292c3 from: Stephen Day date: Thu May 19 20:17:12 2016 UTC Merge pull request #10 from stevvooe/log-unknown-client-tag client: log messages with unknown tags commit - 5eb5d0b15afff9aa87b884374ebc7a692435fef4 commit + f52b87018ad3a5b7f5dd2b21260bb2b0eb0292c3 blob - 955fe76c6b5dd784b27c69d2accec8ae0a264db7 blob + 8a19e3836a0154314bf8f609fbf91e0ea0a29314 --- transport.go +++ transport.go @@ -170,7 +170,12 @@ func (t *transport) handle() { case b := <-responses: req, ok := outstanding[b.Tag] if !ok { - panic("unknown tag received") + // BUG(stevvooe): The exact handling of an unknown tag is + // unclear at this point. These may not necessarily fatal to + // the session, since they could be messages that the client no + // longer cares for. When we figure this out, replace this + // panic with something more sensible. + panic(fmt.Sprintf("unknown tag received: %v", b)) } // BUG(stevvooe): Must detect duplicate tag and ensure that we are