Commit Briefs
-etags ... || true
improves the error that most make implementation given when etags is not present: it doesn't seem scary anymore.
grabkey only on the targeted windows
now we grabkey() only on the window that matches what the user requested. That is, given match class 'Firefox' on "C-n" do "<Down>" we only bind C-n on windows that match the class Firefox, and not on the root window as we did before. In order to do this, we traverse the tree during startup and grabkey on matching windows, than we subscribe also to SubstructureNotify so that when a window gets mapped we receive an event. There are still some downsides to this. Firefox uses also '/usr/local/lib/firefox/firefox' as class name on my machine, and sometimes it seems like we don’t grab the key at the first try (maybe Firefox changes the class after the window gets mapped?)
make grabkey accept the target window as parameter
This is needed so we can later grabkey on particular window and not on the root one.
exec only on key press
it seems to me the most sensible approach
rework send_fake: copy as much as possible from the original event
send_fake now copies almost all field from the original event, except for the the window, keycode and state field. When we grab a key we grab it onto the root window, so every event we receive has a field window that is equal to the root. (this will change in the future), so we need to change that. The keycode and state obviously need to be changed, it's the whole point of the function. It doesn't seem to fix the known bug that occur in dino thought.
explicitly pass -b y to ${YACC}
OpenBSD yacc doesn't require the option (it's the default value after all), but bison do.
trying to improve error message
on some cases, user will get better errors, instead of "foo.conf:5 syntax error". This is the yacc complement for what's been done previously in the parser also.
reworked the tokenizer -- breaking change
The parser was pratically rewritten. Strings now are required to be quoted with single quotes, while keys (still) requires double quotes. In addition, the * is no longer a valid match argument: to match on everything you need to use the special keyword `all'. match all # before was `match *' on "C-a" do "<Home>" # unchanged match class 'Firefox' # before was `match class Firefox' # ...
add exec action for keys
users can now exec command on specifics keys. For example: match class Something on "C-<F5>" do exec my-program
improved error messages
yyerror now is a printf-like variadic function. This helps to generate custom error message like "invalid keysym %s" or "invalid key %s" during parsing.
add ``match *'' to match everything
Rationale: sometimes it can be useful to globally bind a key. For instance, some users may like to bind on "C-<Up>" do "<Page_Up>" for every application.