aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHiltjo Posthuma <hiltjo@codemadness.org>2017-12-27 13:36:53 +0100
committerHiltjo Posthuma <hiltjo@codemadness.org>2017-12-27 13:36:53 +0100
commitdb2236001c1cb042a2f24052849da96578273b1c (patch)
treef98bc6f0534622324ac2e1a32a6d00791bfa4335
parent3756f7f6b8dccf7a31789ffaf073a76fd1a87eb9 (diff)
downloaddwm-retake-db2236001c1cb042a2f24052849da96578273b1c.tar.gz
dwm-retake-db2236001c1cb042a2f24052849da96578273b1c.tar.bz2
dont NUL terminate _NET_WM_NAME
Reported by Kernc, thanks! "This makes a particular program that uses libwnck [1] fail after: Wnck-WARNING **: Property _NET_WM_NAME contained invalid UTF-8 in this code [2] because the returned string contains a '\0' and the documentation for g_utf8_validate() [3] explicitly states that when string length is provided, no nul bytes are allowed." It is not entirely clear it is incorrect, other WM's seem to not NUL terminate it either though.
-rw-r--r--dwm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/dwm.c b/dwm.c
index ff893df..ec6a27c 100644
--- a/dwm.c
+++ b/dwm.c
@@ -1579,7 +1579,7 @@ setup(void)
XChangeProperty(dpy, wmcheckwin, netatom[NetWMCheck], XA_WINDOW, 32,
PropModeReplace, (unsigned char *) &wmcheckwin, 1);
XChangeProperty(dpy, wmcheckwin, netatom[NetWMName], utf8string, 8,
- PropModeReplace, (unsigned char *) "dwm", 4);
+ PropModeReplace, (unsigned char *) "dwm", 3);
XChangeProperty(dpy, root, netatom[NetWMCheck], XA_WINDOW, 32,
PropModeReplace, (unsigned char *) &wmcheckwin, 1);
/* EWMH support per view */