Commit Briefs

1cb79834ea Mark Jamsek

regress: fetch -b/got.conf/wt/remote HEAD interaction

The added test checks we honour the correct precedence of branches to be fetched, which is determined by: the -b flag; branches set in got.conf; the work tree's current branch; and the remote repository's HEAD branch. If a branch is specified with -b, only fetch this branch and if it does not exist, simply report to the user--do not fallback to other branches. Otherwise, if branches are either not set in got.conf or are set but do not exist on the server: - if invoked in a work tree, fallback to the work tree's current branch - if not in a work tree or the work tree's current branch does not exist on the server: - fallback to remote HEAD. With this, only the -b case can result in an unsuccessful fetch due to the requested branch(es) not existing on the server. All other cases will either fetch updates or report "Already up-to-date" (excepting errors). ok stsp@


0dd7613ce6 Mark Jamsek

special case 'got fetch -b <branch>' to only fetch <branch>

As discussed on irc, this drops the implicit remote HEAD fetch when -b is used. got.1 has been updated to make the new fetch behaviour clear. ok stsp@


7b771fb638 Omar Polo

style


0c2ef172a6 Omar Polo

typo


2c4740ad12 Mark Jamsek

style(9): function call in initialiser patch by Mikhail


161b566ff8 Omar Polo

lib/object_create.c: calloc object ids

future fields added to the got_object_id will be implicitly zeroed instead of gibberish. ok stsp@


01392bd604 Tracey Emery

gotwebd: abort tree and blob as well


4f152e84c0 Omar Polo

gotwebd: abort blame if the client disconnect midway thru

Without setting err when the callback fails we continue the blame machinery.


faf054c3d5 Stefan Sperling

make new log message modication check more robust; fixes regress fallout

ok jamsek


ccc835f12a Mark Jamsek

garbage-collect redundant read_logmsg() parameter

As identified and suggested by stsp, with the previous commit, 'strip_comments' is now always set thus no longer needed. ok stsp@


93436ccdaf Mark Jamsek

got: use timestamp and emptiness to validate log message

As suggested by naddy: consider commit log messages valid provided the temp file time stamp has changed and the file is not empty. This heuristic provides the desired behaviour (i.e., reusing cherrypicked/backed-out log messages) that's currently provided but is simpler to grok. Improved by and ok stsp@


4a1dd8cd4f Omar Polo

convert two files to utf8

ok stsp


0c049f812e Stefan Sperling

add a TODO item for gotadmin pack command


08175cbb49 Omar Polo

open_blob: copy whole id not just the sha1