Commit Briefs

Stefan Sperling

add got.conf(5) configuration file

ok tracey


Christian Weisgerber

use the POSIX standard endian functions and explicitly include <endian.h>

ok stsp


Christian Weisgerber

do not rely on <zlib.h> to pull in <unistd.h>

ok stsp


Stefan Sperling

actually make use of an intermediate variable in cmd_clone()

found by tracey's scan-build


Stefan Sperling

in got_object_commit_get_logmsg(), handle log messages which lack '\n'

found by tracey's scan-build


Stefan Sperling

exit the loop in got_privsep_recv_tree() upon error

found while looking over tracey's scan-build results


Stefan Sperling

plug a memory leak in got_privsep_recv_tree() in error case

found while looking over tracey's scan-build results


Stefan Sperling

add -s option to 'got remove' which deletes files in a particular status

This makes it easy to deal with files that were deleted from disk by external tooling which modified the work tree. Such files are left in missing (!) status and can now be marked for deletion in bulk via 'got rm -s\! -R .' For consistency, modified (M) files can now be removed with 'got rm -s M' which implies 'got rm -f'. Prompted by feedback from krw@


Stefan Sperling

add -s option to 'got status' which acts as a status code filter

Advantages over using grep are that the list of codes is validated against a list of known status codes, and that it is easier to match staged files which can display status codes in one or both of two columns. Prompted by feedback from krw@


Stefan Sperling

speed up 'tog diff' get_filestream_info() a bit

With this, 'tog diff' is able to display clang 10 commits. However, such huge diffs still take a rather long time to open. get_filestream_info() is a hack. Ideally, diff line-offset information needed by tog should be part of the result of the diff operation, rather than forcing tog to calculate line offsets during a post-processing step.



Stefan Sperling

fix double-free when quitting tog's diff view; found by ofree

at /home/stsp/src/got/tog/tog.c:3415 3415 free(s->line_offsets); (gdb) bt msg=0x80e2a4cd87e "chunk is already free %p") at /usr/src/lib/libc/stdlib/malloc.c:300 check=1) at /usr/src/lib/libc/stdlib/malloc.c:1070 clear=0, check=<optimized out>, argsz=0) at /usr/src/lib/libc/stdlib/malloc.c:1431 at /usr/src/lib/libc/stdlib/malloc.c:1488 at /home/stsp/src/got/tog/tog.c:3415 at /home/stsp/src/got/tog/tog.c:518 at /home/stsp/src/got/tog/tog.c:954 at /home/stsp/src/got/tog/tog.c:2728 at /home/stsp/src/got/tog/tog.c:5683 (gdb)


Tracey Emery

fix some memory leaks in tog



Stefan Sperling

add a -q option to tests for quiet output and use it for 'make regress'

Previous default output remains when test cases are run individually. ok tracey