Commit Briefs

2fbb00a429 Omar Polo

gotwebd: fix colour of target lines in dark mode

reported by xs on IRC, thanks!


f9a64b1469 James Cook

Test log -b <path> traversing a merge commit.

This tests for the bug fixed by c8255edc. ok stsp@


c8255edc87 Stefan Sperling

handle merge commits that are unrelated to requested changed path history

Problem found and fix tested by James Cook.


fc9b745fd3 Omar Polo

plug some fd leaks in the fdopen{,dir} error paths

There's also a memory leak fixed. ok stsp@


b3be78f908 Omar Polo

style: no-op change in practice

change so it matches the style used in the rest of the tree. ok stsp


7614e0f6e8 Omar Polo

remove stray abort() call; ok stsp


bbca1adf04 Omar Polo

remove unneded wbuf->fd = -1

There's no need to set the fd to -1 on ibufs created with imsg_create(3), and it was probably never needed.


2c52c623be Omar Polo

convert to use imsg_get_fd()

While here also fix a fd leak in got-read-pack. We were dup'ing imsg.fd without closing imsg.fd later; instead just use imsg_get_fd() to extract the file descriptor. Tested by falsifian and Kyle Ackerman, thanks! 'go ahead' stsp@


50b6e2b853 Omar Polo

gotwebd: try to improve copy-paste from BLOB pages

This moves the space inside the line anchor and makes it non-selectable, so that when copy-pasting, only the content of line lines is actually copied. At the moment, this seems to behave slightly incorrectly in firefox which inserts a double line break due to the presence of unselectable elements inside the selection. Hopefully it will be fixed, chromium behaves fine. It also still works decently on text-browsers. ok stsp@


26b163a03e Omar Polo

gotwebd: guard against missig folder and file parameter in BLOB and BLAME

ok stsp


d4fbd6eb2c Omar Polo

allow remotes without urls in git config in gotd

This is b624328edd but for the code used by gotd. ok stsp@


b624328edd James Cook

allow remotes without urls in git config

Also, add tests. This change lets got and related tools work when the git config file has "remote" sections without urls, like this one in one of my git-annex git repositories: [remote "h0-rsync"] annex-rsyncurl = (some url) annex-uuid = (some uuid) skipFetchAll = true Running tog and many got commands there would previously result in: $ tog got-read-gitconfig: gitconfig syntax error tog: gitconfig syntax error The change to got-read-gitconfig.c is by stsp@, with ok from op@ (and now me). Tests ok stsp@.



d0980f09b2 Stefan Sperling

got.1: use typewriter-style quoting in got.conf author example

Otherwise copy/pasting from the man page to got.conf produces syntax errors. Noticed by mlarkin@


cfcfb026c8 Omar Polo

got-read-patch: use imsg_get_fd(), move FILE handling in main

also improves the error message in case of no fd was passed. ok stsp@