Commit Briefs
fix tests for build out-of-tree
now `make distcheck' works as advertised
move load_page_from_str to telescope.c
I'd like to use parser{,_gophermap,_gemtext}.c in standalone testing programs, and this function is getting in the way since it depends on ui.c
parsers: add serialize function
Add a parser_serialize function and an optional function `serialize' for parsers. The default implementation just prints the text line, which is suitable for parser_textplain and parser_textpatch; gemtext and gophermap uses their own specific unparse functions. This is intended for an incoming cache refactoring: we'll cache the page serialized in the correct format, not once it has been translated to gemtext. This will allow in the future to provide commands such as ``save page to disk'' or interface with an on-disk cache.
add fn pointer to the parser init function to struct parser
will come in handy in the future cache refactoring.
correctly save scrolling position
Before we didn't save the scrolling position before a refresh (nohist=1) and that's annoying. This saves the scrolling position only in the correct case, which is when changing from a page to another, expect when switching to TAB_LAZY off.
move TAB_LAZY flipping from switch_to_tab in load_url
load_url needs to know when a tab passes from lazy to not lazy to correctly saves the scrolling position (see follow-up commit.)
typo in parse_session_line
without +4 strtonum sees top=X and cur=Y which are invalid numbers, so the scroll position is lost.
don't reset scroll position if the cursor changed line
If the user managed to move the cursor before the page load, don't restore the scroll position. This is to avoid unnecessary jumping and causing possible confusion on the user.
save and restore scroll position
Save the offset to the first and current line of the buffers and restore it when the page is loaded. This restores almost the exact viewport: we save the offset of the *real* line in the document, but they get wrapped before being displayed, so the actual restored position may be slightly above from the original one (think of a long paragraph that gets wrapped over multiple visual lines.) In practice, this isn't a drawback but only an improvement over the current behaviour. In the future we could save also the offset *inside* the line, to restore the exact position, but that felt unnecessary for now. Persisting the postion on the session file ensures that even when re-opening telescope the scroll position is correct. There are some very active pages, such as antenna or other aggregator, where this feature doesn't really work well if you re-open the page after a while, since new links are available, but otherwise is a god sent! See also github issue #1