Commit Briefs
don't change params if they're the same
avoids a sio_stop in the common case of switching from song that needs similar params (such as tracks in the same album.)
s/player_setrate/player_setup
when the function was renamed, the error messages weren't.
use a strictier pledge for `amused add'
now that we're using canonpath instead of realpath(3), we can drop the rpath pledge promise.
use canonpath instead of realpath(3)
so we get the same behaviour with `add' and `load'
use getprogname(3) instead of __progname
might help with portability, see for e.g. GitHub issue #1
avoid unnecessary initialization
we're just gonna memcpy all over path again a couple of lines before; a smart compiler will probably ignore the initialization anyway.
s/audio_init/player_init
was the only function to disrespect the player_* namespace (well, excepting play). while here also don't mark those two as static, they were the only static functions in the file. I'm not trying to enforcing private symbols here.
no need to sio_setpar during initialization
we don't know what format the music will be so we have to stop and set the parameters in player_setup. there's no point in setting bogus parameter in audio_init.