Commit Briefs

Omar Polo

fix various compilation errors

Include gmid.h as first header in every file, as it then includes config.h (that defines _GNU_SOURCE for instance). Fix also a warning about unsigned vs signed const char pointers in openssl.


Omar Polo

accept4 -> accept

accept4(2) isn't part of any standard (even though it'll be part in the future) and raises warnings on some linux distro. Moreover, we don't have thread that may fork at any time, so doing a mark_nonblock after isn't a big deal.


Omar Polo

BUFSIZ is variable, we need *exactly* 1024

Using BUFSIZ in sbuf is not OK. It's variable, and in various places we assume that sbuf is 1024 (like handle_cgi_reply). We could patch those, but we aren't sure BUFSIZ is >= 1024! Let's keep the hardcoded number. (found by debugging on arch on amd64, where BUFSIZ is bigger)


Omar Polo

typo



Omar Polo

echo parsing test result


Omar Polo

don't mmap

Before we mmap(2) file for reading, and use a buffer to handle CGI scripts. Turns out, for sequential access over the whole mmap isn't better than our loop on read. This has also the additional advantage that we can use handle_cgi (now handle_copy) for both files and CGI, which is pretty cool. This also fixes a nasty bug where we could hang a connection forever, because we scheduled the wrong type of event (read on POLLOUT and write on POLLIN, it's the other way around!)


Omar Polo

fix config reload

the old server processes would stick around waiting on the signals events. While there, also drop the `struct server_events' and define events as globals.


Omar Polo

dup line


Omar Polo

improve compat/getprogname on GNU libc

but why'd they called it program_invocation_short_name? They couldn't find a longer name?



Omar Polo

add -levent in the example


Omar Polo

use fatal instead of err/fprintf+exit

fatal logs to the correct place, err only on stderr.