Commit Briefs

Omar Polo

fix memory leak in walk_path error path

found by clang' static-analyzer




Omar Polo

9pclib: send size in wstat

This is the counterpart for the recent kamid commit about wstat: we're lacking the leading size field.


Omar Polo

wstat: missing read for size

9p stat message have a leading 2 bytes long size field. It's meant to simplify the parsing, because while reading the contents of a directory it's necessary to know how much long an entry is, so the length field is present even in the Rstat reply and in the Twstat input. Previously we didn't consume that bit and thus mis-read all of the following fields.





Omar Polo

work around wstat limitation

the previous commit added an explicit check for extra data in messages. The problem is that wstat voluntarily skips reading some fields at the end, so the len will always be greater than zero!


Omar Polo

fail if the received packet is too long

This adds extra checks to every t* function: if the client sent too much data per message, treat is an a protocol violation and terminate the connection. Regress suite still passes, this is just an extra safety check for finding wrong clients implementations. The twrite function was the only one with a check like this.


Omar Polo

fix np_read{8,16,32,64} functions

they should return 0 on failure, not -1


Omar Polo

kamid: change fid fname size to NAME_MAX

the fname field is just the file name, so NAME_MAX is more appropriate. Committing this separately from the rename change so it's easier to roll back eventually.


Omar Polo

kamid: rename field fpath to fname

it's actually just the file name, not a path


Omar Polo

fmt


Omar Polo

ftp: document rename