Commit Briefs


Omar Polo

gotwebd: add fcgi_printf

instead of fcgi_gen_response which outputs only a fixed strings provide a printf-like fcgi_printf: it greatly simplifies the generation of the HTML pages. While here also (probably) fix some HTML errors: the output was verified with the W3C validator and it's correct (in the sense that the tags are properly closed, there are still some other things the validator complains about.) ok/encouragement baseprime@, ok jamsek Thanks for reading such a boring diff!


Omar Polo

fix overflow in blame callback

spotted by noticing gotwebd crashing on some blame requests. Diff from stsp@ with a fix from tracey@, I'm committing it only because he is short on time. ok stsp@


Stefan Sperling

gotwebd: initialize IPv4 and IPv6 sockets in the same way

ok tracey


Stefan Sperling

gotwebd: don't listen on FCGI sockets when FCGI is not enabled

ok tracey


Stefan Sperling

gotwebd: do not allocate server/socket list heads separately

ok millert@


Stefan Sperling

gotwebd: do not allocate address list heads separately, this is unnecessary

ok millert@


Omar Polo

fix snprintf error handling

follow the "proper secure idiom" described in the CAVEATS section of printf(3). reminded by tb@ and millert@


Omar Polo

convert two snprintf to strlcpy

"looks good to me" millert@


Omar Polo

check for fprintf failure


Stefan Sperling

got(1): Replace 'Ar sign' with 'Cm sign'

Cm sign matches the markup used in the ssh-keygen(1) man page. Patch by Josiah Frentsos



Stefan Sperling

Group options in accordance with style(9)

patch by Josiah Frentsos


Omar Polo

gotwebd: fix double free in gotweb_process_request

don't free the querystring, it's already done later by fcgi_celanup_request. ok tracey@


Stefan Sperling

tog: add missing checks for NULL pointers in log view state

ok jamsek