Commit Briefs

Stefan Sperling

free id and path in load_packed_tree_ids() on error, else they would leak

pointed out by op@


Stefan Sperling

fix wrong line wrap; pointed out by op@



Stefan Sperling

implement object enumeration support in got-read-pack

ok op@


Omar Polo

got stage: implicitly unstage when staging the reverse of the staged diff

otherwise we end up with a staged empty edit for that file. ok stsp@



Stefan Sperling

convert delta cache to a hash table

This approach uses more memory but is much faster. To offset the additional memory usage somewhat the cache now stores very small deltas only. However, overall memory usage goes up. Hopefully we will find a way to reduce this later. ok op@



Omar Polo

don't pass $ret to test_done on failure when it's known to be zero

Otherwise the test directory it's not left in place; ok tracey@


Stefan Sperling

properly swap cached struct pack array elements in got_repo_cache_pack()

Avoids clobbering open files for delta base/accumulation, leaking file descriptors, and triggering errors from close(2) during got_repo_close() as we try to close the same file descriptor more than once.


Stefan Sperling

move creation of tempfiles outside of lib/diff.c

ok tracey



Stefan Sperling

reduce GOT_PACK_CACHE_SIZE to 32, otherwise it uses too many open files

found by tracey


Stefan Sperling

ensure that all open basefd/accumfd get closed in got_repo_close()

found by tracey


Stefan Sperling

open temporary files needed for delta application in got_repo_open()

This prepares for callers of got_repo_open() that cannot afford to open files in /tmp, such as gotwebd. In a follow-up change, we could ask such callers to pass in the required amount of open temporary files. One consequence is that got_repo_open() now requires the "cpath" pledge promise. Add the "cpath" promise to affected callers and remove it once the repository has been opened. ok tracey