Commit Briefs

Florian Obser

Correctly track if we sent more data since the last time we looked.

With the narrow scope of bytes_sent_cur it would always be zero, and we would always update progress. Found by llvm's scan-build (Dead store). OK stsp


Florian Obser

Prevent use-after-free of packed_refs_path in error path.

Found by llvm's scan-build. OK stsp


Florian Obser

Prevent memory leak when asprintf fails.

Found by llvm's scan-build. OK stsp


Florian Obser

Make sure got_repo_pack_fds_close() frees a malloc'ed pointer.

Found by llvm's scan-build (bad free). OK stsp


Florian Obser

If the first readdir() returns NULL err is uninitialized.

This can't happen in practice, but llvm's scan-build doesn't know this. OK stsp


Florian Obser

We don't care about the length of the read line.

Found by llvm's scan-build (dead store). OK stsp


Florian Obser

Do not ignore error from got_pathlist_append.

Found by llvm's scan-build (dead store). OK stsp


Florian Obser

Do not ignore error from format_author().

Found by llvm's scan-build (dead store). OK stsp


Florian Obser

Dot not ignore error from got_object_id_str().

Found by llvm's scan-build (dead store). OK stsp


Florian Obser

path_got is unused and never assigned, no need to free it

OK stsp


Florian Obser

Do not ignore I/O errors.

Found by llvm's scan-build (dead store). OK stsp


Florian Obser

Don't chug along if repo format version is unsupported.

Found by llvm's scan-build (dead store). OK stsp


Christian Weisgerber

gotwebd: fix potential type mismatch between format specifier and argument

ok tracey


Mark Jamsek

tog: blame view keymap to open log of annotated line

As per stsp's TODO item: open a log view of the selected line with 'L'. helped by and ok stsp@