Commit Briefs

Omar Polo

change (again) the env/param separator: use '='

Given that env/param are new features of this release, no support for the "old" syntax is needed.


Omar Polo

add => in env/param and `port' between hostname and port for fastcgi

In the same spite of the last commit, add the missing separators between strings to avoid the auto-concat pitfalls. `=>' is used to separate between `env' and `param' arguments, while for `fastcgi' the keyword `port' is required between the hostname/ip address and the port (if provided). Since `env', `param' and `fastcgi' are all new stuff, there's no need to keep compatibility.


Omar Polo

typo...


Omar Polo

rename `mime MIME EXT' to `map MIME to-ext EXT'

With the newish automatic string concatenation, options like `mime' that accepts two strings as parameter start to become ambiguous: which strings gets concatenated? Instead of trying to document in the manpage which argument(s) is subject to string concatenation, do the concat always and introduce a separator. In the case of mime, `to-ext' now acts as a separator to distinguish. While there, also use a new keyword because it sounds better. It's dead-easy to upgrade to the new configuration, possibly with some sed magic, but for the moment the old `mime' form is preserved: (with a warning!) Will be dropped in the next release.


Omar Polo

use bsearch to match the keywords

not that it's a bottleneck, but it's fancier this way.


Omar Polo

provide a means to skip the runtime tests

Setting the environment variable SKIP_RUNTIME_TESTS to 1 will prevent the runtime tests. This is useful when running the tests inside a sandbox. based on a similar diff by Anna "CyberTailor"



Omar Polo

check freedesktop's libbsd



Omar Polo

PF_UNIX is not a valid protocol for socketpair

OpenBSD accept it, but FreeBSD disallows it. PF_UNSPEC (or 0) should be used instead. The FastCGI bit in the regress suite still doesn't work on FreeBSD, but at least now it starts.


Omar Polo

don't leak a file descriptor

make sure we always close every fd in every possible code path; while there, also add a log_err if fork(2) failed.


Omar Polo

style(9)-ify


Omar Polo

always append -W flags to CFLAGS


Omar Polo

initialize the logger early

Initialize the logger as soon as possible and log by default to stderr. With this, some (common?) errors are printed early instead of ending up in syslog. # NB: this is in configless mode % ./gmid -p 80 [2021-07-07 11:05:57] bind: Address already in use % ./gmid -p 81 [2021-07-07 11:13:53] bind: Permission denied %


Omar Polo

refactor add_{cflags,ldflags}