Commits
- Commit:
0c64c2f8032e7c3de8b5b3ca5c5bd9047b89b17c
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: clean up sockets_create_socket a bit
Instead of hardcoding the flags, keep ai_{family,socktype,protocol}
from the getaddrinfo() call and apply them here.
ok stsp@
- Commit:
cdfd248aa718819d40d0bf972b7efbb2eabd31c9
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotadmin: get rid of got_sockaddr.[ch] usage
It was added due to gotwebd weird structure sockaddr_storage handling.
Instead, save the size reported by getaddrinfo() and not reach into
the struct sockaddr_storage at all (except for extracting the port
number for diagnostics purposes.)
sockets_conf_new_socket_fcgi() gets an hardcoded ipproto to zero
(which is the only value it can get in practice, and keeps for the
moment the hardcoded SOCK_STREAM. It'll be cleaned in a follow-up.
ok stsp@
- Commit:
b8b20b3c52fa4f90a1ac5b20e7d8a24fae8d9e27
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: improve error message in get_addrs(); noticed by stsp@
- Commit:
89cfaaa7b56bbfa063ed42929ced2ab244443f62
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: make get_addrs() take the service name directly
This changes how we handle the port number: bubbles up the local
portstr added in previous commit and lets getaddrinfo() deals with
port numbers and services name. getservice() can be gc.
While here add the missing free() in parse.y.
ok stsp@
- Commit:
dfd77022fc31b33c39f1e800698a2d43644666fa
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix typo in previous
- Commit:
c5e111b920bf4b059fe47aa7dcee5630ad5c3363
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: merge host() and get_addrs(); use * instead of "" for any addr
ok plus tweaks stsp@
- Commit:
af09dd3fec1090c7273f680a0ae5bf50d2183390
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: disable listening on interfaces
ok stsp@
- Commit:
63c6b10f7b78b600251e3eb2622e0db7db0f8aa0
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reduce gotwebd pledges to the minimum currently required; with op@
- Commit:
6fe3b58aaa9bdb466eabad75eb65bce86d7155af
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix gotwebd unveil permissions
The main process doesn't need write access anywhere and /tmp is not needed.
The sockets process didn't use unveil at all so far, but is happy with
just "x" for libexec helpers and "r" for each server's repository path.
Input from op@
Tested by myself and Kyle Ackerman who also reviewed the diffs.
Prompted by questions from mlarkin@
ok mlarkin@, op@
- Commit:
b1c090542f4ecaf993fc81468338839febcb8e37
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
allow setting variables in gotd.conf; code from gotwebd/parse.y
ok op@
- Commit:
a3dc2f5de198c4a5c70d7b2be4db9179531c4456
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: remove dead ipproto handling in host() and host_if()
ipproto is always -1, so delete the dead code. ok stsp@
- Commit:
91f3651eacab82fa74052cacf1b8b5fdf9b05267
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use ibuf_fd_set() instead of reaching into the ibuf struct
discussed with tb@
- Commit:
ac4f092c7c8e090ee733c90b8b0f0274872c8662
- From:
- Omar Polo <op@omarpolo.com>
- Date:
don't redundantly set wbuf->fd to -1
ibuf_dynamic() (called by imsg_create()) already initializes fd to -1.
- Commit:
2161bc24065b9b58f71cbffbb8b65a9546e134f2
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix some fd leaks in error paths and avoid some double close
Sweep done after a few were spotted by tb@, thanks!
ok stsp@
- Commit:
e2766b2cfe846879e3e4de660bc7e7af350a384b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd TODO: category grouping support