Commits
- Commit:
638823f847d99e105ee6671fe1c51f8f048a0e48
- From:
- Omar Polo <op@omarpolo.com>
- Date:
don't reset scroll position if the cursor changed line
If the user managed to move the cursor before the page load, don't
restore the scroll position. This is to avoid unnecessary jumping and
causing possible confusion on the user.
- Commit:
e795e9355a607cbda3790e5c651c1a6f829e4326
- From:
- Omar Polo <op@omarpolo.com>
- Date:
save and restore scroll position
Save the offset to the first and current line of the buffers and restore
it when the page is loaded. This restores almost the exact viewport: we
save the offset of the *real* line in the document, but they get wrapped
before being displayed, so the actual restored position may be slightly
above from the original one (think of a long paragraph that gets wrapped
over multiple visual lines.) In practice, this isn't a drawback but
only an improvement over the current behaviour.
In the future we could save also the offset *inside* the line, to
restore the exact position, but that felt unnecessary for now.
Persisting the postion on the session file ensures that even when
re-opening telescope the scroll position is correct.
There are some very active pages, such as antenna or other aggregator,
where this feature doesn't really work well if you re-open the page
after a while, since new links are available, but otherwise is a god
sent!
See also github issue #1
- Commit:
8f1633da06463e8909dbf68a870aa64350f32a12
- From:
- Omar Polo <op@omarpolo.com>
- Date:
simplify parse_session_line
drop sendtab which is not that useful and send the tab to the ui
process directly in parse_session_line. It's easier to skip malformed
session lines too!
- Commit:
68b634ad2803674767d0a5f1b4cf4f47ee6a9a39
- From:
- Omar Polo <op@omarpolo.com>
- Date:
sync changelog
- Commit:
1ebb7ceb0d8d1e6a521913f38003908bc21bd571
- From:
- Omar Polo <op@omarpolo.com>
- Date:
fix parsing of invalid link lines
Links lines without an URL may crash Telescope if the emojify-link
option is enabled (which is by default.) Since URLs are mandatory in
link lines, parse these invalid lines as empty text lines (lagrange
and phos parses them as text lines with "=>".)
thanks @aartaka for unknowingly helping finding this issue, see
https://github.com/omar-polo/phos/pull/5
- Commit:
2e44d6be3e7033f0206cd6584ff31953aedc76a9
- From:
- Omar Polo <op@omarpolo.com>
- Date:
grammar
- Commit:
83f1c5102d05a3b6ce489bf0702a4760167d07d4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
sync changelog
- Commit:
1e0f5c02fa8fbc9b2e9166d51ec1be329eb7a931
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add alias open for load-url, suggested by Florian, thanks :)
- Commit:
ef5d883cad082af249521441e30abe1fe8074255
- From:
- Omar Polo <op@omarpolo.com>
- Date:
move aliases at the top of the completions
it's easier to match them this way
- Commit:
ab251513680a7c02b5bc403602d6ed73a680181e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
start new release cycle
- Commit:
a2fe40fe5ab44489d4316e650361fe19a181d3dc
- From:
- Omar Polo <op@omarpolo.com>
- Date:
update site for 0.7.1
- Commit:
84b0c4ab06e6de6c071c3cac39b0df011cf23ff5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
tag 0.7.1 -- bugfix release
fix use after free when loading an about:* page from about:about.
Reported by Brian Callahan, thanks!
- Commit:
0b9a2b9206b2123bae3a2ae8893348d4ae7b90a6
- From:
- Omar Polo <op@omarpolo.com>
- Date:
sync changelog
- Commit:
52a99c568d70787741ab72597d29960acb78c738
- From:
- Omar Polo <op@omarpolo.com>
- Date:
avoid possible use after free
`url' may be a pointer to a string of the buffer which gets corrupted
upon tab_stop.
This bug shows when loadfn is load_about_url, because in
make_fs_request we first tab_stop, and then send the request, which
ends up sending to the fs process a free'd string. At least on
OpenBSD with Otto' malloc is (partially) corrupted and will either
make the fs process abort or return a not found page.
One solution may be to rework make_fs_request to process things in a
different order, but that would only hide the problem. Instead, use
the newly created history element as url given to the loadfns: that is
guaranteed to be valid up to the next load_url call.
Reported by Brian Callahan, thanks!
- Commit:
2122686bb1ab8ef51c4a4c94189be287c5512dff
- From:
- Omar Polo <op@omarpolo.com>
- Date:
start a new release cycle