Commits
- Commit:
8a2a5b8f2568a665f00741994c1247f0f7d3dffe
- From:
- Xi Wang <xi.wang@gmail.com>
- Via:
- Russ Cox <rsc@swtch.com>
- Date:
libsec: avoid undefined C
gcc compiles `p + length < p' into 'length < 0' since pointer overflow is undefined behavior in C. This breaks the check against a large `length'.
Use `length > pend - p' instead.
There's no need to check `length < 0' since `length' is from length_decode() and should be non-negative.
===
Try the simplified code.
void bar(void);
void foo(unsigned char *p, int length)
{
if (p + length < p)
bar();
}
$ gcc -S -o - t.c -O2
...
foo:
.LFB0:
.cfi_startproc
testl %esi, %esi
js .L4
rep
ret
.L4:
jmp bar
.cfi_endproc
Clearly `p' is not used at all.
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/7231069
- Commit:
01e3847b7e6ff87f72a34a42cd98425e569250f6
- From:
- Russ Cox <rsc@swtch.com>
- Date:
xd: accept -S for 8-byte swap
R=rsc
https://codereview.appspot.com/7565045
- Commit:
36bb28dc638bb3091e05996156b5fbecbc67dcd5
- From:
- Russ Cox <rsc@swtch.com>
- Date:
devdraw: control+click = button 2, alt/shift+click = button 3
For single-button mouse users.
R=rsc
https://codereview.appspot.com/7620043
- Commit:
17934beda0895d1b584e09f0253b8205b7fd6de2
- From:
- Russ Cox <rsc@swtch.com>
- Date:
devdraw: silence unused variable warnings
R=rsc
https://codereview.appspot.com/7304064
- Commit:
5154e54d8b8ee864f31f0774ee590be87a1d6e02
- From:
- Russ Cox <rsc@swtch.com>
- Date:
devdraw: disable XCopyArea optimization
Ubuntu Precise seems to have a buggy X server
that sometimes fails at XCopyArea. Let devdraw
do it itself.
This will slow down remote X a little bit,
but slow and correct is better than fast and broken.
R=rsc
https://codereview.appspot.com/7310069
- Commit:
cac1425c4a48d9bdead08249ccfc0ba5d0156b97
- From:
- Alessandro Arzilli <alessandro.arzilli@gmail.com>
- Via:
- Russ Cox <rsc@swtch.com>
- Date:
fontsrv: fix on X11 when X11H is not defined
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/7228044
- Commit:
0dc3aa4b1dcca64ca747de9ceb05f0033f884bd6
- From:
- Xi Wang <xi.wang@gmail.com>
- Via:
- Russ Cox <rsc@swtch.com>
- Date:
libmach: fix crash in dwarfpc (misuse of realloc)
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/7225059
- Commit:
dad9d0ac8faf5482c0305a1da7356b1b1982c0a0
- From:
- Martin Neubauer <m.ne@gmx.net>
- Via:
- Russ Cox <rsc@swtch.com>
- Date:
fontserv: fix build on FreeBSD 9.1
R=rsc
https://codereview.appspot.com/7095050
- Commit:
0497ad9724e9b2bf60191dd1d54876aaa9e568a3
- From:
- Russ Cox <rsc@swtch.com>
- Date:
CONTRIBUTORS: three more
R=rsc
https://codereview.appspot.com/7225073
- Commit:
d5baaf984f95dd79f58c7a17c57cc6cccca9f8a2
- From:
- David du Colombier <0intro@gmail.com>
- Date:
jpegdump: fix build and warnings
R=rsc
https://codereview.appspot.com/7070070
- Commit:
23efb34d47df2cb993547995a532a6bf7333f08b
- From:
- David du Colombier <0intro@gmail.com>
- Date:
freq: fix crash with utf > 0xffff (thanks Andrey Mirtchovski)
R=rsc
https://codereview.appspot.com/7029054
- Commit:
0798d6b7417c2c0fbdff759fab6a91c1030044f4
- From:
- David du Colombier <0intro@gmail.com>
- Date:
venti/wrarena: fix arenapart breakage
R=rsc
https://codereview.appspot.com/7027044
- Commit:
cb71c0bdc4f605fceafe10ffd2959af693290145
- From:
- Russ Cox <rsc@swtch.com>
- Date:
fontsrv: only build when the pieces are there
- Commit:
1a512ec048a5c607a01b9fd82561c1601ba87406
- From:
- Christian Kellermann <ckeen@pestilenz.org>
- Via:
- Russ Cox <rsc@swtch.com>
- Date:
fontsrv: fix build on OpenBSD 5.2
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/6850108
- Commit:
0b4fd921055175e9dda8c424f9252f4141507742
- From:
- David du Colombier <0intro@gmail.com>
- Date:
auth/factotum: fix password prompt hang with secstore
R=rsc
http://codereview.appspot.com/6906057