Commits
- Commit:
6227cf0ee49b322cc297ef95bdad09ea8eae2ec4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix usage of the commit graph iter
got_get_repo_commits mixes ids allocated on the heap and the one
returned by the iter_next in the same variable, and then even attemp to
free it.
This is both a leak (we loose the pointer to the previously allocated
id) and a possible invalid free since the object id pointer returned by
the graph iterator is not to be passed to free(3).
part of a bigger diff that's ok stsp@
- Commit:
b94206d0acc1c55bad1233c35f959fa7c4af297b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free obj_id and reflist in got_output_file_blame
ok stsp@
- Commit:
a33a44db81f52e0217b4e38e2e180442521f37ad
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: got_output_file_blame: free lines on error path
ok stsp@
- Commit:
8a4f92ca904ede1f7a5e7e1bafdf8be7974943ed
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free eline in got_gotweb_blame_cb loop
ok stsp@
- Commit:
e4213243b6508845e530a1aadef9fe28d49a1ff2
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: drop superfluous check
commit_id is not NULL if got_repo_match_object_id returned
successfully. ok stsp@
- Commit:
e5e662e42c45f0d30f5f97fb0e2ad5f3c4f8b488
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: kill unused id_str in got_output_repo_tree
ok stsp@
- Commit:
2c6b597256598f3a2f21b529eef551b51db5adb5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: avoid extra strdups in got_output_repo_tree
ok stsp@
- Commit:
6977f45a0d6e4dceb507913771e10106042dbaca
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: avoid extra variable in got_output_repo_tree
in_repo_path was used only to build a path, it's then assigned to path
(which is NULL at that point.) Just asprintf into path.
ok stsp@
- Commit:
4a962942057bae9fbd47916e75d554fb52e0ec37
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: plugs leaks in got_get_repo_commits
call got_get_repo_commit only once and avoid leaking the field of
repo_commit at each loop iteration.
ok stsp@
- Commit:
dfa5768dfba3067f15757fc77677e1ba43b33b57
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free in_repo_path in got_get_repo_commits; ok stsp@
- Commit:
bce44e0b80af65d03bd0422e6468d7055e76b848
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: always free ref in got_get_repo_commits
some code-paths may leak it. ok stsp@
- Commit:
bc95141ca7ce90e4b19a251b36c87601c150bb3f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: don't close tag in got_get_repo_tags too early
it's still used a bit later, so defer the free'ing at the next loop
iteration or at function end.
- Commit:
5a57034b6f08eec784b8fe3c0b0b734eb2d4605a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free commit_msg0 only at the end of got_get_repo_tags
in case of a failure between when it's allocated and when it's released
it might get leaked otherwise.
ok and semplification stsp@
- Commit:
b163541dd9b5a61e6be0e3956ab1ed2c591aace5
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: plug some leaks in got_get_repo_tags
ok stsp@
- Commit:
625e5896fc9ecf87ccfc92ad2a65cd3be58f73c0
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: free all allocated fields of repo_tag
got_get_repo_tags needs some tweaking to how tag_commit is allocated
too.
ok stsp@