Commit Diff

Commit:
dcb5b83a7470b57af0f2d26f6fbe6810308b13aa
From:
Omar Polo <op@omarpolo.com>
Date:
Message:
extract the filtering to its own function I got tired of `n` a millions of time when debugging vc-got-dir-status-files, so I extracted it to its own function. (yeah, I could have used a conditional breakpoint, but I feel this is more readable)
Actions:
Patch | Tree
commit - 76d978fa0c79a15471dc879b9abacee1914292ae
commit + dcb5b83a7470b57af0f2d26f6fbe6810308b13aa
blob - f4c2417291b19c244f4f5abfa20558df332e4cd6
blob + 3dec6b932a4e9f3256893cbc1f6da8c892c07549
--- vc-got.el
+++ vc-got.el
@@ -406,16 +406,20 @@ files on disk."
           (if (eobp)
               'up-to-date
             (vc-got--parse-status-char (char-after))))))))
+
+(defun vc-got--dir-filter-files (files)
+  "Remove ., .. and .got from FILES."
+  (cl-loop for file in files
+           unless (or (string= file "..")
+                      (string= file ".")
+                      (string= file ".got"))
+           collect file))
 
 (defun vc-got-dir-status-files (dir files update-function)
   "Build the status for FILES in DIR.
 The builded result is given to the callback UPDATE-FUNCTION.  If
 FILES is nil, consider all the files in DIR."
-  (let* ((fs (seq-filter (lambda (file)
-                           (and (not (string= file ".."))
-                                (not (string= file "."))
-                                (not (string= file ".got"))))
-                         (or files (directory-files dir))))
+  (let* ((fs (vc-got--dir-filter-files (or files (directory-files dir))))
          (res (vc-got--status nil dir files)))
     (cl-loop for file in fs
              do (when (and (not (cdr (assoc file res #'string=)))