Thanks to Akshat Kumar for reporting this issue. LGTM=seed, rsc R=rsc, seed https://codereview.appspot.com/173770043

fixed warnings: src/cmd/fossil/disk.c:37:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:38:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:39:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:40:13: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/cmd/fossil/disk.c:41:14: warning: use of GNU 'missing =' extension in designator [-Wgnu-designator] src/libndb/ndbreorder.c:41:55: warning: for loop has empty body [-Wempty-body] ignored warnings: src/cmd/acid/dbg.y:393:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/bc.y:1327:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/grep/grep.y:420:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/hoc/hoc.y:692:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/lex/parser.y:886:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/rc/syn.y:303:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/cmd/units.y:1003:9: warning: array index -1 is before the beginning of the array [-Warray-bounds] src/libregexp/regcomp.c:19:16: warning: variable 'reprog' is not needed and will not be emitted [-Wunneeded-internal-declaration] LGTM=rsc R=rsc https://codereview.appspot.com/158250043

Found by nwf. TBR=rsc https://codereview.appspot.com/162860045

TBR=rsc https://codereview.appspot.com/158240043

LGTM=rsc R=rsc https://codereview.appspot.com/136520044

On NetBSD 5.0 and upper, mount() require data_len as a fifth argument. LGTM=rsc R=rsc CC=elbingmiss https://codereview.appspot.com/111600043

LGTM=rsc R=rsc CC=plan9port-dev https://codereview.appspot.com/119500043

LGTM=rsc R=rsc CC=plan9port-dev https://codereview.appspot.com/115100043

TBR=rsc https://codereview.appspot.com/112890043

R=rsc https://codereview.appspot.com/92650043

TBR=rsc https://codereview.appspot.com/107760043

They'll be copied back during installation but then hg doesn't have to create those files on systems that have trouble with them. TBR=rsc https://codereview.appspot.com/105800043

Acme tracks the most recent typing insertion point and the home and end keys stop there on their way up to the top or down to the bottom of the file. That point should be iq1, and it should be adjusted properly so that it's always between 0 and t->file->b.nc inclusive. (This is all code from an external contributor, years old at this point but new since Plan 9.) Somehow, sometimes iq1 ends up a little beyond b.nc, and when passed to textbacknl it crashes acme in bufread. I can't see how that can happen but if it does, avoid the crash. It's tempting to pull the insertion point code out entirely but this is a little less invasive and should fix things for now. TBR=rsc https://codereview.appspot.com/107730043

We ran for a long time with 10ms kernel resolution, so 10ms user space resolution here should be fine. Some systems actually provide 1ms sleeps, which makes this polling use a bit more cpu than we'd like. Since the timers are for user-visible things, 10ms should still be far from noticeable. Reduces acme's cpu usage on Macs when plumber is missing (and plumbproc is sleeping waiting for it to appear). LGTM=aram, r R=r, aram https://codereview.appspot.com/99570043

This breaks ^C in win windows, as expected. People use ^C, win expects and handles ^C, so I don't think we can just take it away. I've noticed that it is broken but assumed my ssh was screwed up. If you want to make WindowsKey+C,X,V do the operations, by analogy with command+C,X,V on Mac, that's fine with me. ««« original CL description acme: copy/cut/paste with ctl+c,x,v LGTM=rsc R=rsc CC=plan9port.codebot https://codereview.appspot.com/69070045 »»» TBR=rsc CC=burns.ethan, r https://codereview.appspot.com/96410045