The actual implementation is based off doas' parse.y. This gave us various benefits, like cleaner code, \ to break long lines, better handling of quotes etc...

leftover from the handle_imsg_log -> do_log transition.

nobody really cares if must_read fails, as it normally shouldn't. It only clutters the regression tests with scary messages that looks like failure but are, in fact, expected.

the logger process now can receive a file descriptor to write logs to. At the moment the logic is simple, if it receives a file it logs there, otherwise it logs to syslog. This will allow to log on custom log files.

and while there reorder the targets in the Makefile a bit

Yep, fd should be the file descriptor, but for lazyness when manually calling the function sometimes we supply 0 as fd and event. Instead of fixing the usage, do as other of such functions do in this circumstances: use c->fd.

otherwise clients will remain stuck waiting for a pending request that doesn't exist (see apply_fastcgi switch.)

it's not technically required, since a couple of lines below we free whole host struct, and we don't have code that may use h->{env,aliases} afterwards, but it's nice not to have invalid pointers around. it may bite in the future.

man -Tlint