Commit Briefs

Russ Cox

man: various cleanup

Change-Id: I9130e7d10ae42e894923097a7c97da802eb0d8c3 Reviewed-on: https://plan9port-review.googlesource.com/2962 Reviewed-by: Russ Cox <rsc@swtch.com>


Russ Cox

codereview.py: remove

Change-Id: Ie548b7f45f4b3aa9897bcba19d343cff2dd5afd4 Reviewed-on: https://plan9port-review.googlesource.com/2961 Reviewed-by: Russ Cox <rsc@swtch.com>


Russ Cox

man5, man6: delete empty dirs

Change-Id: Iff3843740d98f5fb79499d3b6024333361dfe755 Reviewed-on: https://plan9port-review.googlesource.com/2960 Reviewed-by: Russ Cox <rsc@swtch.com>


Russ Cox

man1: document mouse keystrokes in acme, sam, 9term

Change-Id: Id99ce9a143a21009d93a1c6ba2d1f84a3588649f Reviewed-on: https://plan9port-review.googlesource.com/2942 Reviewed-by: Russ Cox <rsc@swtch.com>


Russ Cox

acme: implement Cmd-Shift-Z for Redo on Mac

Change-Id: Ie9332ed473609bd6ca156be0843dc5411cbf7b93 Reviewed-on: https://plan9port-review.googlesource.com/2941 Reviewed-by: Russ Cox <rsc@swtch.com>


Russ Cox

devdraw: fix Mac Kcmd+Shift

Change-Id: Ide32a9397701085b17fbd42f0866eb3de11e4190 Reviewed-on: https://plan9port-review.googlesource.com/2940 Reviewed-by: Russ Cox <rsc@swtch.com>


Russ Cox

fontsrv: avoid quote mapping on fonts with indistinguishable quotes

Fixes #86. Change-Id: Id487219a0fcfdb68133fc81b11383365a1431c1c Reviewed-on: https://plan9port-review.googlesource.com/2922 Reviewed-by: Russ Cox <rsc@swtch.com>


Russ Cox

lib9: fix needsrcquote

As written, it is passing a rune to strchr, which likely ignores all but the bottom 8 bits of the rune. Long-standing Plan 9 bug too. Fixes #87. Change-Id: I6a833373b308bed8760d6989972c7f77b4ef3838 Reviewed-on: https://plan9port-review.googlesource.com/2921 Reviewed-by: Russ Cox <rsc@swtch.com>


Russ Cox

svgpic: new program to convert pic to svg

This is an experiment. Like tpic it's a copy-and-paste fork of pic. Change-Id: Ia22772bd5881c7904a6d8f8e0b46fde8cea89cbd Reviewed-on: https://plan9port-review.googlesource.com/2920 Reviewed-by: Russ Cox <rsc@swtch.com>


David du Colombier

troff: import HB, HI and HX fonts from Plan 9

These font were accidentally left out, because their name conflicted with Hb, Hi and Hx fonts on case-insensitive file systems. These fonts were later renamed to longer names. Fixes #84. Change-Id: Ia0631f270a8cee6bee4337c4557837bba1a405ab Reviewed-on: https://plan9port-review.googlesource.com/2900 Reviewed-by: Russ Cox <rsc@swtch.com>


Gleydson Soares

factotum: Fix an operator precedence bug in the secstore code

`==` is higher precedence than `&`. Parenthesize. Change-Id: I2c7ee588fea0d8a66e1c8424f26630015388d61a Signed-off-by: Dan Cross <cross@gajendra.net> Reviewed-on: https://plan9port-review.googlesource.com/2860 Reviewed-by: Gleydson Soares <gsoares@gmail.com>


Russ Cox

yacc: Fix a bug from at least 1995.

Fix a bug folding newlines in strings constants in C code snippets in YACC. This code has existed since at least 2nd Edition Plan 9. Change-Id: Iba17b89a6529ac9fa6610bf0b44f551904174c26 Signed-off-by: Dan Cross <cross@gajendra.net> Reviewed-on: https://plan9port-review.googlesource.com/2840 Reviewed-by: Russ Cox <rsc@swtch.com>


Gleydson Soares

libdraw: replace hand-rolled realloc, preventing buffer overflow.

The original buffer is f->nsubf*sizeof *subf bytes (oldsize) large. Once it's full, a new buffer of (f->nsubf+DSUBF)*sizeof *subf (newsize) is mallocated. Unfortunately memmove() reads (newsize) bytes from the original (oldsize) buffer, causing a buffer overflow. By switching to realloc(), we don't need to do buffer size calculation, memmoving, and freeing of the original buffer. Change-Id: Ibf85bc06abe1c8275b11acb1d7d346a14291d2cd Reviewed-on: https://plan9port-review.googlesource.com/1520 Reviewed-by: Gleydson Soares <gsoares@gmail.com>


Gleydson Soares

9term: Add missing parentheses, preventing buffer overflow.

(el-sr) is the string length and (sizeof wdir - strlen(name) - 20) is the buffer size. When the string length is greater than the buffer size, the beginning of the string is supposed to be trimmed to fit in the buffer size. Unfortunately a pair of parentheses were missing, pointing sr outside the buffer, and the for loop below then reads outside the buffer. For certain binary data printed in a window, it causes a segfault. Change-Id: Iffeaa348260ee2a5a36d9577308fb8d1c1688d05 Reviewed-on: https://plan9port-review.googlesource.com/1540 Reviewed-by: Gleydson Soares <gsoares@gmail.com>


Russ Cox

9pfuse: support osxfuse>=3.3.0

Change-Id: Ibca68261016b0f588e169e9f319748b5ba7d15ac Reviewed-on: https://plan9port-review.googlesource.com/2700 Reviewed-by: michaelian ennis <michaelian.ennis@gmail.com> Reviewed-by: Russ Cox <rsc@swtch.com>